Interestingly, people are hanging onto devices for longer but battery life seems to hold out. It was standard for the mothership Dell batteries to die after a couple of years (not always spectacularly, fortunately). Blackberries (remember them) also tended towards suicidal batteries, though at least they were easily and cheaply replaced.
My iPhone 6 is good for a day plus of normal use and I can't, tbh, think of a reason to update it. Things like face-ID might be cool, but really opening it with a fingerprint isn't a labour, all the apps I use still run plenty fast and I can do everything I need. I'll probably only upgrade when it doesn't hold a day's charge, Apple stop providing the updates, or I drop it in a puddle.